Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-8024] Let ClusterOverviewHandler directly extend from AbstractRestHandler #4982

Closed
wants to merge 2 commits into from
Closed

[FLINK-8024] Let ClusterOverviewHandler directly extend from AbstractRestHandler #4982

wants to merge 2 commits into from

Conversation

tillrohrmann
Copy link
Contributor

What is the purpose of the change

Let ClusterOverviewHandler directly extend from AbstractRestHandler.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@tillrohrmann
[FLINK-8000] Sort Rest handler URLS in RestServerEndpoint
18d8d1a 
Introduce special RestHandlerUrlComparator to sort REST URLs such that
URLs with path parameters are sorted after those without or fewer.

E.g. the following order would be established

/jobs
/jobs/overview
/jobs/:jobid
/jobs/:jobid/config
/:*
@tillrohrmann
[FLINK-8024] Let ClusterOverviewHandler directly extend from Abstract…
bdc5d0e 
…RestHandler
zentol
zentol approved these changes Nov 8, 2017
View reviewed changes
Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tillrohrmann tillrohrmann mentioned this pull request Nov 8, 2017
Closed
@tillrohrmann
Copy link
Contributor Author

Thanks for your review @zentol. Merging.

@asfgit asfgit closed this in f03393e Nov 9, 2017
@tillrohrmann tillrohrmann deleted the generalizedClusterOverviewHandler branch November 9, 2017 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zentol zentol zentol approved these changes

Assignees
No one assigned
Labels
component=Runtime/REST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tillrohrmann @zentol @rmetzger